Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issues with the demo project #387

Open
atifaziz opened this issue Aug 25, 2015 · 2 comments
Open

Fix build issues with the demo project #387

atifaziz opened this issue Aug 25, 2015 · 2 comments

Comments

@atifaziz
Copy link
Member

Purpose of code changes on this branch:

Fix issues #382 and #384

When reviewing my code changes, please focus on:

https://code.google.com/r/jamesdriscoll71-demo-project-issues

After the review, I'll merge this branch into:
/trunk


Originally reported on Google Code with ID 387

Reported by @JamesDriscoll on 2015-03-10 00:04:49

@atifaziz
Copy link
Member Author

Subject: revision 1c036c80b7d0

I'm not in favour of changing the project type just because NuGet does not support Web Site projects. May be NuGet needs to be fixed!

The Demo web site is meant to be a simple sample and a Web Site project maintains that simplicity.

That all said, I'm surprise that Web Site projects are not supported. Towards the end of section “Automatic Package Restore in Visual Studio” of the “NuGet Package Restore” documentation, it says clearly that one of the advantages of the new system is “Compatibility with ASP.NET Web Site projects created in Visual Studio.” Is that only when restoring from within VS as opposed to the command line?

If Web Site projects are not supported, I would resort to the old working approach of prestore.cmd but giving the packages.config path explicitly to nuget restore instead of letting it guess. For example, this can be achieved with the single command line of (assuming a current directory of the solution root):

for /f %p in ('dir packages.config /s/b ^| findstr /v /i PrecompiledWeb') do @nuget restore -PackagesDirectory .\packages %p

It doesn't matter whether we approach that through nugetRestore.proj or a batch.


Reported by @atifaziz on 2015-03-10 06:19:43

@atifaziz
Copy link
Member Author

Reported by @atifaziz on 2015-03-10 06:19:54

  • Status changed: Started

@atifaziz atifaziz assigned atifaziz and unassigned elmah Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant