Skip to content
This repository has been archived by the owner on Nov 11, 2023. It is now read-only.

Display PDF files inline (in an iframe) #87

Closed
rugk opened this issue May 16, 2016 · 3 comments
Closed

Display PDF files inline (in an iframe) #87

rugk opened this issue May 16, 2016 · 3 comments

Comments

@rugk
Copy link

rugk commented May 16, 2016

Similar to displaying included image files it would also be nice to display PDF files directly.

Usually you would just need to create an iframe where the PDF file is loaded. Modern browsers do the rendering itself (Firefox e.g. uses PDF.js) or display it with browser plugins.

If you do you might of course sandbox the iframe correctly.

@rugk rugk changed the title What about displaying PDF files in an iframe Display PDF files inline (in an iframe) May 16, 2016
@nitmir
Copy link

nitmir commented May 18, 2016

Or use pdf.js for every one and add a download button for then pdf.js do not render well ?

édith: it's what owncloud do btw

@rugk
Copy link
Author

rugk commented May 18, 2016

This would also be possible, but I'm not sure whether pdf.js would bloat this too much...

@elrido
Copy link
Owner

elrido commented Jul 9, 2016

This issue was migrated to #14.

@elrido elrido closed this as completed Jul 9, 2016
elrido added a commit that referenced this issue Aug 21, 2016
Replace icon with logo with text
elrido pushed a commit that referenced this issue Aug 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants