Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project still active? #5

Open
quazzuk opened this issue Oct 16, 2022 · 3 comments
Open

Is this project still active? #5

quazzuk opened this issue Oct 16, 2022 · 3 comments

Comments

@quazzuk
Copy link

quazzuk commented Oct 16, 2022

Hi

I think this is a really good idea, are you planning on continuing to develop? Need any help?

I would like to look at adding websocket support and generally exposing more functionality. Is the list of features in the README.md accurate or just taken directly from ether-rs?

Thanks
Andy

@elyase
Copy link
Owner

elyase commented Oct 16, 2022

hi thanks for reaching out. The project is stalled rn, I still want to continue developing, it is just that a lot of stuff came at the same time and had to pause it.
So your contribution would be very valuable. The list of features is taken from ethers-rs. At the moment the only thing that works is example in the tests (so block and balance).
Re websocket, I looked quickly into it but noticed I lack pyo3 skills :-) (see awestlake87/pyo3-asyncio#17), but for sure it would be a great addition.

@quazzuk
Copy link
Author

quazzuk commented Oct 16, 2022

Hey.

Ok, cool. I had a few questions:

  1. Are you using maturin at the moment? I see in in the requirements-dev.txt. I seem to be able to build with maturin develop too.
  2. what's generate_stubs.py for?
  3. Have you any thoughts on whether code generation can be used and/or how abigen might be used to support contract objects?

Thanks
Andy

@elyase
Copy link
Owner

elyase commented Oct 17, 2022

Hey Andrew,

  1. Yes maturin develop is the right way and is what the release script in .github uses, added some dev setup instructions to the readme
  2. Goal is to keep the docs in sync with the code. The docs are generated by sphinx but sphinx can't see inside rust source code so this script generates stubs inside py_src which sphinx can pick up. I think there are better alternatives now like pdoc.
  3. I had some thoughts but forgot about it so would have to rethink from scratch :-). But my impression was that it should be possible

Please let me know if there is something I can do to help you get coding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants