Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropbox Feature is outdated #53

Open
LukasFratzl opened this issue May 8, 2022 · 1 comment
Open

Dropbox Feature is outdated #53

LukasFratzl opened this issue May 8, 2022 · 1 comment

Comments

@LukasFratzl
Copy link

LukasFratzl commented May 8, 2022

The Dropbox feature has 2 major issues:

  1. It does not work out of the box, it requires adding another method into the “DropboxDownloader” -> public override void Download(string url, string destFolder, Action<long> onChunkDownloaded) and this method is when we convert it 1 to 1 to Dropbox Code not multithreaded.

  2. Dropbox got a Terms of Service Update back in September 2021 which changes the OAuth workflow, the new workflow says it's no longer possible to create “Long living Tokens” but the App can request an “Short living Token” from the Dropbox Server which can be used as temporary credentials while using the patcher. Here is an example in c# of the new OAuth workflow Github Dropbox API Example. Using just an “Short living Token” makes the patcher not connect any more after some hours with the same token.

I'm currently editing the Files for my own game so once I've done it I can send a Pull Request or sharing the Code to the PATCH Authors to review and use.

@RobbyWD
Copy link

RobbyWD commented Sep 23, 2022

Hey there Lukas, could you please send me the working examples of the DropboxDownloader please? Can't make it work properly. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants