Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve logging for fetchRevisions #52

Open
ghedamat opened this issue Feb 6, 2016 · 3 comments
Open

improve logging for fetchRevisions #52

ghedamat opened this issue Feb 6, 2016 · 3 comments

Comments

@ghedamat
Copy link
Contributor

ghedamat commented Feb 6, 2016

Currently fetchRevisions is fired both on deploy and deploy:list

the log messages in the hook are NOT marked as verbose but they should be for the deploy command as they lead to confusing output for the users
@achambers
Copy link
Member

I notice ember-cli-deploy the other day this also is probably bred when running deploy:activate. Kind of confusing

@ghedamat
Copy link
Contributor Author

ghedamat commented Feb 7, 2016

Yup @achambers

That's exactly the culprit.

Happy to chat about a decent solution!

@achambers
Copy link
Member

I hadn't looked in to why it happens yet. Let's chat about it. Keen to hear
your thoughts.
On Sun, 7 Feb 2016 at 12:40, Mattia Gheda [email protected] wrote:

Yup @achambers https://github.com/achambers

That's exactly the culprit.

Happy to chat about a decent solution!

—
Reply to this email directly or view it on GitHub
#52 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ghedamat @achambers