Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue with npm link of ember-cli on windows. #22

Open
stefanpenner opened this issue Dec 4, 2016 · 6 comments
Open

issue with npm link of ember-cli on windows. #22

stefanpenner opened this issue Dec 4, 2016 · 6 comments
Labels

Comments

@stefanpenner
Copy link
Collaborator

version ends up being undefined for ember-cli all the time. Might something to do with symlinks/junctions on windows?

@stefanpenner stefanpenner changed the title issue with npm link on windows. issue with npm link of ember-cli on windows. Dec 4, 2016
@rwjblue
Copy link
Member

rwjblue commented Dec 4, 2016

It's possible, I'll update my ievms and try to repro locally.

@stefanpenner
Copy link
Collaborator Author

@rwjblue i'll try tonight/tomorrow to debug this. I have a good local reproduction, just tired so i figured I would leave a reminder issue :)

@Turbo87 Turbo87 added the bug label Dec 5, 2016
@rwjblue
Copy link
Member

rwjblue commented Mar 23, 2020

Curious if this is still an issue.

@suchitadoshi1987
Copy link

@rwjblue @stefanpenner I am having the same issue. I am running yarn link and .exists() always returns undefined

@stefanpenner
Copy link
Collaborator Author

@suchitadoshi1987 are you sure? This issue I believe is windows specific. Do you have a reproduction handy?

@MrChocolatine
Copy link

I am not sure it's 100 % related to the same issue but I am also getting undefined when checking the version property of a package.

I was trying to work on this PR:
typed-ember/ember-cli-typescript#1142

And as we can see in the original PR, the author left a note:

Seems like somehow VersionChecker isn't getting the dependencies in the ember-cli-blueprint-test-helpers context 🤔

I am also getting the same error.

I tried to dig into this and it turns out, for some reason I don't understand, the following function resolvePackagePath returns null for the package ember-data (while it is correctly detected in the dependencies of the project):

this._jsonPath = resolvePackagePath(this.name, basedir);

Because this._jsonPath is set to null, the following if() that are supposed to set this._version are not entered and the property stays undefined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants