-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrites escaped quotes to quotes (causing Template Compiler Error) #219
Comments
@kategengler nice one! I’ll try to look at it in 2019 😆. Seriously I’ll try to at least get my head wrapped around this in the next day or so. |
with input fixture like this the test fails let input = `
{{foo-bar placeholder="Choose a \"thing\" here"}}
`; But if the input fixture has double slashes like this, the test passes. let input = `
{{foo-bar placeholder="Choose a \\"thing\\" here"}}
`; |
@kategengler Out of curiosity, it is recommended not to use bare strings in templates right? Aren't you folks using any template-lint rules with |
@rajasegar |
@kategengler Makes sense, understood. |
@kategengler @rajasegar there is a fix pending. It might be in the new |
@tylerturdenpants So the fix would be to just bump |
@rajasegar yes. I reopen a dependabot closed PR that would have down that but it looks like maybe another issue made its way through. |
was rewritten to
The text was updated successfully, but these errors were encountered: