New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should this use the Addon.prototype.isEnabled flag instead? #58

Open

stefanpenner opened this issue Feb 8, 2019 · 3 comments

stefanpenner commented Feb 8, 2019

Should this use the Addon.prototype.isEnabled flag instead?

At first glance, it appears this add-on simply wants itself to be skipped if not needed, this may be a simpler approach.

Member

rwjblue commented Feb 8, 2019

Simpler than?

Author

stefanpenner commented Feb 9, 2019

guarding functionality with https://github.com/rwjblue/ember-angle-bracket-invocation-polyfill/blob/master/index.js#L60 shouldPolyfill

Member

rwjblue commented Feb 9, 2019

Sure, I see. Ya, definitely could change it but it honestly doesn’t seem simpler to me...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment