Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework objects look to be included in undestroyed objects when calling assertDestroyablesDestroyed #159

Open
nlfurniss opened this issue May 5, 2021 · 0 comments

Comments

@nlfurniss
Copy link

Overview

ember-lifeline recently switched to using assertDestroyablesDestroyed from ember-destroyable-polyfill in one of its test helpers. Depending on the version of Ember being used, a very simple test of a very simple component will fail with leftover undestroyed objects. This is the repro repo.

image

Ember versions that work/don't work

The test in the repro app fails depending on the Ember version being used

3.18.1 ✅
3.20.0 ✅
3.20.1 ✅
3.20.2 🔴 <<<< Update Glimmer rendering engine to 0.54.2. Fixes an issue with (private for now) destroyables work to enable the destroyables polyfill to work more appropriately.
3.20.6 🔴
3.24.4 🔴
3.27.x 🔴

This is the initial ember-lifeline issue

cc: @snewcomer @rwjblue @scalvert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant