Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the IE11 addEventListener polyfill optional #4

Open
buschtoens opened this issue Feb 15, 2019 · 1 comment
Open

Make the IE11 addEventListener polyfill optional #4

buschtoens opened this issue Feb 15, 2019 · 1 comment
Labels
build enhancement New feature or request

Comments

@buschtoens
Copy link
Collaborator

buschtoens commented Feb 15, 2019

IE11 has an incomplete and buggy implementation of Element#addEventListener, which is why I have added event-listener.js in #2 to make this addon just work™️ in IE11.

This polyfill is of course not required, if the targeted browsers do not include IE11.

We should add a config option to allow excluding the polyfill from the build. Ideally this option would by default depend on the support for { once: true } in the browsers defined in config/tragets.js, so that users don't need to configure this manually.

@buschtoens buschtoens added enhancement New feature or request build labels Mar 5, 2019
@buschtoens
Copy link
Collaborator Author

The polyfill now also adds a hard assertion against calling event.preventDefault() for passive event listeners. If the polyfill may be excluded, this assertion has to be moved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant