Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to flexbox from neat (grid system) #118

Open
kategengler opened this issue Jul 16, 2018 · 5 comments
Open

Move to flexbox from neat (grid system) #118

kategengler opened this issue Jul 16, 2018 · 5 comments

Comments

@kategengler
Copy link
Member

No description provided.

@yohanmishkin
Copy link
Contributor

yohanmishkin commented Jul 16, 2018 •
edited
Loading

Ahoy! I can take a stab at this.

Here's where I'm seeing neat grid usage. Does that sound right to you?

@kategengler
Copy link
Member Author

Hey! Those are the correct files but there are many more usages within those files. Looking forward to your PR :)

This was referenced Jul 17, 2018
Merged
Merged
This was referenced Jul 27, 2018
Merged
Merged
@kategengler kategengler mentioned this issue Aug 25, 2018
Merged
@kaermorchen
Copy link
Contributor

Why not to move to other grid system which based on flexbox (like bootstrap 4)?

@kategengler
Copy link
Member Author

Because we don't need a grid system -- with the work @yohanmishkin did, there's likely only 1-2 places left that neat is used.

This was referenced Sep 2, 2018
Closed
Closed
@yohanmishkin
Copy link
Contributor

I think we're close!

The remaining work here will be checking for any other usage of variable, mixins, functions, etc. noted here.

@yohanmishkin yohanmishkin mentioned this issue Mar 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kategengler @yohanmishkin @kaermorchen