Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure and test that running in the browser is appropriately supported #11

Open
NullVoxPopuli opened this issue Jul 11, 2023 · 1 comment

Comments

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Jul 11, 2023

Use case (for me, anyway):

This would fix an issue with Safari, where my copied ember-template-imports code's regex is not compatible with Safari.

We'll need to make sure no "extra stuff" (plugins, etc) are included in the build as browsers are more sensitive to extraneous bytes (on the embroider call today, Ed mentioned that he thinks this is already happening 🎉 ).

@NullVoxPopuli
Copy link
Contributor Author

Confirm that this isn't currently compatible with the browser:

const path = require('path').join(__dirname, 'content_tag_bg.wasm');
const bytes = require('fs').readFileSync(path);

neither path, nor fs exists in the browser.

So, we probably need to tweak how content-tag is compiled to support both.

Test PR here: NullVoxPopuli/limber#1162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant