Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embroider resolver favours v2 addon template over app template for routes #2074

Open
void-mAlex opened this issue Aug 23, 2024 · 3 comments
Open

Comments

@void-mAlex
Copy link
Collaborator

given a v2 addon with a following appReeports [
... ,
'routes//*.js',
'templates/
/*.js',
]
with a route ./template/test.gjs (hbs works as well because they both get compiles to js files)

and an app that has its own ./template/test.hbs

you will get the addon template resolved instead of the app one even though the expectation is that the app should win

@NullVoxPopuli
Copy link
Collaborator

I've observed this as well

@simonihmig
Copy link
Collaborator

Seeing a similar thing happening for (instance-)initializers!

@kdagnan
Copy link

kdagnan commented Oct 10, 2024

Seeing similar behavior for a service.

A v2 addon’s service is favored over the app’s service.ts with the same name, in the same place. Interestingly, if it’s a .js file (in the app) it’s fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants