Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work in MS Edge or IE11 #28

Open
careyestes opened this issue Sep 9, 2019 · 3 comments
Open

Doesn't work in MS Edge or IE11 #28

careyestes opened this issue Sep 9, 2019 · 3 comments

Comments

@careyestes
Copy link

careyestes commented Sep 9, 2019

Load up https://etcdevteam.github.io/hashicon/examples/ in Edge or IE and you will see it doesnt load the icons. Ive implemented it using React and get a few js errors in the console.

Both the hashicon demo site and my localhost get this:
image

Will support for Edge and IE be added?

@oori
Copy link
Collaborator

oori commented Sep 10, 2019

Yes. The current code is written in modern javascript (ES6), we need to transpile for older browsers (I'm surprised IE Edge doesn't handle it..).
TODO: Babel (as rollup plugin) will solve this.

@cwbutler
Copy link

@oori, I see that babel is commented out in the rollup config file. Is this intentional? Will uncommenting the plugin fix?

@oori
Copy link
Collaborator

oori commented Sep 26, 2019

Nope.. Using "rollup-plugin-babel" is the start, but requires more.
Lack of time and need pushes this down on my TODO list, but I'll try to do it soon.
PR welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants