Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying extra manifests via Helm for emissary-ingress chart #5706

Open
oponomarov-tu opened this issue Jun 25, 2024 · 0 comments
Labels
t:feature New feature or enhancement request

Comments

@oponomarov-tu
Copy link

Please describe your use case / problem.

It would be very beneficial to supply extraManifests value to the emissary-ingress Helm chart that would render extra manifests as a part of a single Helm chart deployment.

Describe the solution you'd like

An extra variable to hold a list of arbitrary Kubernetes manifests, e.g.

## Extra manifests to deploy as an array
extraManifests: []
  # - apiVersion: elbv2.k8s.aws/v1beta1
  #   kind: TargetGroupBinding
  #   metadata:
  #     name: internal-emissary-ingress
  #   spec:
  #     serviceRef:
  #       name: internal-emissary-ingress
  #       port: 80
  #     targetGroupARN: <target group arn>

Describe alternatives you've considered

  1. Building a Helm chart wrapper to include emissary-ingress Helm chart as a subchart.
  2. Using Kustomize with overlays.
  3. Deploying the extra manifests in a separate Helm chart / Kustomize overlay.

The (1) & (2) are hard to maintain and scale, the (3) introduces the dependency between deployments which requires putting the stuff in correct order.

Additional context

This has been a normal practise and a lot of OSS Helm charts support such options these days, e.g.

I'm willing to implement this feature.

@cindymullins-dw cindymullins-dw added the t:feature New feature or enhancement request label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:feature New feature or enhancement request
Projects
None yet
Development

No branches or pull requests

2 participants