Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all .restext files have been removed #219

Open
kebox7 opened this issue Dec 16, 2024 · 2 comments
Open

Not all .restext files have been removed #219

kebox7 opened this issue Dec 16, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@kebox7
Copy link

kebox7 commented Dec 16, 2024

Describe the bug

According to the information from the History of PDFsharp & MigraDoc project, all .restext files should have been removed in PDFsharp 6.2.0 Preview 1. This is not entirely true, after building the project the .\bin\Publish\de\MigraDoc.Rendering.resources.dll file appears.

Additional context

  • OS: Windows 10 Pro Build 19045.4651
  • Runtime: .NET 9.0.0
  • PDFsharp-MigraDoc 6.2.0 Preview 2
@ThomasHoevel
Copy link
Member

Describe the bug

According to the information from the History of PDFsharp & MigraDoc project, all .restext files should have been removed in PDFsharp 6.2.0 Preview 1. This is not entirely true, after building the project the .\bin\Publish\de\MigraDoc.Rendering.resources.dll file appears.

As far as I can tell, all *.restext files have been removed.
The DE folders no longer exist in the NuGet packages.

It is correct that a DE folder is created for the MigraDoc.Rendering project. This can safely be removed when distributing the software.

We'll fix that with the next release.

@kebox7
Copy link
Author

kebox7 commented Dec 19, 2024

It is correct that a DE folder is created for the MigraDoc.Rendering project. This can safely be removed when distributing the software.

I'm aware, that's exactly what I'm doing.

The reason for what is happening is most likely this:

<ItemGroup>
<EmbeddedResource Update="Rendering\MdPdfMsgs.de.resx">
<SubType>Designer</SubType>
</EmbeddedResource>
<EmbeddedResource Update="Rendering\MdPdfMsgs.resx">
<SubType>Designer</SubType>
</EmbeddedResource>
</ItemGroup>

We'll fix that with the next release.

That would be great.

@ThomasHoevel ThomasHoevel added the bug Something isn't working label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants