Skip to content
This repository has been archived by the owner on Aug 30, 2021. It is now read-only.

Fix noise osc #25

Closed
yupferris opened this issue Oct 13, 2015 · 2 comments
Closed

Fix noise osc #25

yupferris opened this issue Oct 13, 2015 · 2 comments

Comments

@yupferris
Copy link
Member

Seems to be wrong in the chrono trigger song "ruined world". It may be something else, but the wind in that song has a lot of jumps in pitch that don't make sense.

@yupferris
Copy link
Member Author

#28 would probably help track this down

@yupferris
Copy link
Member Author

After testing thoroughly in a debugger and checking the code, I couldn't find any obvious errors. Then, I double-checked against the reference from the OST (recorded from hw), and in fact there's no bug at all. The pitch modulation was only more noticeable because of linear resampling (to be fixed in #1) and lack of a post filter (to be fixed in #23).

So, not an issue after all. The emu is correct in this regard already.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant