Use verify_rows and verify_columns

[topper-123]

Hi @TomAugspurger ,

Thanks for this great library, I use it a lot.

A lot of verification is done row-wise and/or column-wise. Engarde has some specific row/column functions, but I suggest adding functions that take generic functions that operate on rows/columns:

That means we can do something like this generically:

@verify_columns({'A': lambda col: col.sum() > 5})
@verify_rows(lambda row: row.A > row.B)
def add(df1, df2):
    return df1 + df2

This functionality would by default verify that all checks pass, but by setting how='any', we could also check that just any row/column pass the test (example: verify_rows(lambda row: row.A > row.B, how='any')).

Would you accept a pull request along these lines?

[TomAugspurger]

The current way of doing this would be with @verify_all

@verify_all(lambda df: df.A > df.B)
def add(df1, df2):
    return df1 + df2

Still, it'd probably be nice for condition functions that aren't vectorized, so yeah this seems sensible.

by setting how='any', we could also check that just any row/column pass the test

I'd prefer separate functions like verify_rows_all and verify_rows_any. I try to avoid using keyword arguments in functions that also take **kwargs, since you can have conflicts between which function that keyword applies to.

[topper-123]

I looked into this again tonight.

I've made an implementation locally, but it's different than my Github fork of engarde, and I'd like to keep that. Do you happen to know if I can upload a pull request to your repository without deleting my fork?

[TomAugspurger]

IIUC you should be able to checkout a new branch and push that as a PR

…

________________________________ From: topper-123 <[email protected]> Sent: Tuesday, September 12, 2017 6:30:35 PM To: TomAugspurger/engarde Cc: Tom Augspurger; Mention Subject: Re: [TomAugspurger/engarde] Use verify_rows and verify_columns (#48) I looked into this again tonight. I've made an implementation locally, but it's different than my Github fork of engarde, and I'd like to keep that. Do you happen to know if I can upload a pull request to your repository without deleting my fork? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#48 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABQHIsdHWe6qE7-M8UletwBJiQILKM7bks5shxQXgaJpZM4PLH6z>.