Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for the unhappy path of signing #150

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dvdplm
Copy link
Contributor

@dvdplm dvdplm commented Sep 25, 2024

I noticed that the test for the signing protocol does not traverse the unhappy path, where signature verification fails and we generate a correctness proof for the verifying signer. So here's a test for that along some more testing utils.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 98.16514% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.51%. Comparing base (9f9a0c4) to head (9d83fdb).

Files with missing lines Patch % Lines
synedrion/src/cggmp21/protocols/signing.rs 98.16% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
+ Coverage   90.72%   92.51%   +1.78%     
==========================================
  Files          44       44              
  Lines        8066     8137      +71     
==========================================
+ Hits         7318     7528     +210     
+ Misses        748      609     -139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dvdplm
Copy link
Contributor Author

dvdplm commented Sep 30, 2024

@fjarri A review on this would be nice, so we can get rid of CI failures due to missing coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant