Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can the echo round be expressed in terms of the typed rounds framework? #70

Closed
fjarri opened this issue Nov 19, 2023 · 1 comment
Closed

Can the echo round be expressed in terms of the typed rounds framework? #70

fjarri opened this issue Nov 19, 2023 · 1 comment
Labels
code quality Making things simpler
Milestone
v1.0.0

Comments

@fjarri
Copy link
Member

fjarri commented Nov 19, 2023 •
edited
Loading

The echo round has a "special" status now, and does not implement the traits from round submodule. Is that a good idea? Should we try to make it a "normal" round so that we don't need a "normal round"/"echo" switch in the Session object? Note that we may need to keep that special status to implement message piggybacking for broadcast consensus (see #62, #114)
@fjarri fjarri added the code quality Making things simpler label Nov 19, 2023
@fjarri fjarri added this to the v1.0.0 milestone Nov 26, 2023
@fjarri fjarri changed the title Can the broadcast consensus round be expressed in terms of the typed rounds framework? Can the echo round be expressed in terms of the typed rounds framework? May 3, 2024
@fjarri
Copy link
Member Author

fjarri commented Oct 12, 2024

This is done in manul. Closing.

@fjarri fjarri closed this as completed Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Making things simpler
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@fjarri