Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove parametrization by the signature type in the Session layer? #72

Closed
fjarri opened this issue Nov 19, 2023 · 1 comment
Closed

Remove parametrization by the signature type in the Session layer? #72

fjarri opened this issue Nov 19, 2023 · 1 comment
Labels
API Involves backwards-incompatible changes of the public API code quality Making things simpler
Milestone
v1.0.0

Comments

@fjarri
Copy link
Member

fjarri commented Nov 19, 2023

Session and related API are all parametrized by Sig which is the signature type, because it is stored in a typed way in SignedMessage. Instead, we could store the serialized signature there, removing the need for parametrization. This may make the code simpler, but adds a little overhead. Need to try and see if it's worth it.
@fjarri fjarri added API Involves backwards-incompatible changes of the public API code quality Making things simpler labels Nov 19, 2023
@fjarri fjarri added this to the v1.0.0 milestone Nov 26, 2023
@fjarri
Copy link
Member Author

fjarri commented Oct 12, 2024

Discussion moved to entropyxyz/manul#6

@fjarri fjarri closed this as completed Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Involves backwards-incompatible changes of the public API code quality Making things simpler
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@fjarri