Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle .unwrap()s gracefully #76

Open
fjarri opened this issue Nov 19, 2023 · 0 comments · May be fixed by #147
Open

Handle .unwrap()s gracefully #76

fjarri opened this issue Nov 19, 2023 · 0 comments · May be fixed by #147
Labels
API Involves backwards-incompatible changes of the public API code quality Making things simpler
Milestone

Comments

@fjarri
Copy link
Member

fjarri commented Nov 19, 2023

As a temporary measure, there's a number of unwrap() throughout the code base. These need to be removed and replaced with error propagation. When it's done, warn(clippy::unwrap_used) in lib.rs should be enabled (or even changed to deny). Also look for assert!.

@fjarri fjarri added API Involves backwards-incompatible changes of the public API code quality Making things simpler labels Nov 19, 2023
@fjarri fjarri added this to the v0.2.0 milestone Nov 26, 2023
@dvdplm dvdplm linked a pull request Sep 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Involves backwards-incompatible changes of the public API code quality Making things simpler
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant