Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive BaseRound::NEXT_ROUND_NUM automatically #78

Closed
fjarri opened this issue Nov 20, 2023 · 2 comments
Closed

Derive BaseRound::NEXT_ROUND_NUM automatically #78

fjarri opened this issue Nov 20, 2023 · 2 comments
Labels
code quality Making things simpler
Milestone
v1.0.0

Comments

@fjarri
Copy link
Member

fjarri commented Nov 20, 2023 •
edited
Loading

Theoretically, we can calculate BaseRound::NEXT_ROUND_NUM based on BaseRound::ROUND_NUM and whether the round implements FinalizableToResult (then it's None) or FinalizableToNextRound (then it's BaseRound::ROUND_NUM + 1).
@fjarri fjarri added the code quality Making things simpler label Nov 20, 2023
@fjarri fjarri added this to the v1.0.0 milestone Nov 26, 2023
@fjarri
Copy link
Member Author

fjarri commented May 7, 2024

Actually: do we even need ROUND_NUM/NEXT_ROUND_NUM at all at the typed level? The round number is not used anywhere, and if Session needs it, it can just as well count the rounds itself.

@fjarri
Copy link
Member Author

fjarri commented Oct 12, 2024

Invalidated by the more dynamic nature of manul (where there actually can be several possible rounds following the finalization).

@fjarri fjarri closed this as completed Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Making things simpler
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@fjarri