Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown component used across the UI is missing localized string for case when no options are available #1379

Open
esuomi opened this issue May 23, 2024 · 2 comments

Comments

@esuomi
Copy link
Collaborator

esuomi commented May 23, 2024

In various places, such as when creating a new line or selecting an authority to a new network, if there's no options available at all, the dropdown component shows

Ingen treff for søket

as the default text;
Screenshot 2024-05-23 at 15 23 09

This string is not localized. From what I can gather, it seems to come from within the component itself (@entur/dropdown?) and since it repeats everywhere where the dropdown component is used, the problem should be isolated in the component itself.

@testower
Copy link
Collaborator

Thanks for reporting! I actually noticed this while working on a fix for #1377. There should definitely be a more sensible and localized placeholder value here.

@testower
Copy link
Collaborator

So this seems to be an issue with the component itself. I'll report it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants