Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Figure out policy for module specific code owners #2882

Closed
mattklein123 opened this issue Mar 23, 2018 · 4 comments
Closed

RFC: Figure out policy for module specific code owners #2882

mattklein123 opened this issue Mar 23, 2018 · 4 comments
Assignees
Milestone

Comments

@mattklein123
Copy link
Member

Once #2069 is complete, we will be in a better position to have module specific code owners for extensions. This is good, because the number of requests to add extensions to the main repo is growing. We need to figure out the right way to scale this. I have a bunch of thoughts on this which I will write up within the next couple of weeks but going to open this now in case anyone in the community would like to share their thoughts.

cc @envoyproxy/maintainers

@mattklein123 mattklein123 added this to the 1.7.0 milestone Mar 23, 2018
@mattklein123 mattklein123 self-assigned this Mar 25, 2018
@alyssawilk
Copy link
Contributor

I like the idea of "you add it, you own it" as a start, but that obviously doesn't work well if that person wants to hand off ownership for [reasons] and there's folks using the code who are users but not contributors to Envoy. I don't have solid ideas of what to do there, so I look forward to hearing your thoughts :-)

@mattklein123
Copy link
Member Author

@envoyproxy/maintainers and other interested parties: I drafted a short document on a proposed policy for how extensions will be added to the repository in the future. Please comment!
https://docs.google.com/document/d/1eDQQSxqx2khTXfa2vVm4vqkyRwXYkPzZCcbjxJ2_AvA/edit#

@alanconway
Copy link

I will shortly have an extension to contribute, your policy proposal seems reasonable.

dynamic loading #2053 would facilitate externally maintained and packaged extensions without having to build a modified envoy binary, which potentially reduces your burden even more.

You might want a naming scheme for external extensions, e.g.

  • internal "envoy.filters.network.amqp_http"
  • external "qpid.apache.org/filters.network.amqp_http"

@mattklein123
Copy link
Member Author

@alanconway agreed on both accounts re: dynamic loading and naming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants