Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which algorithm ratelimit process is using ? #269

Closed
santinoncs opened this issue Jul 26, 2021 · 2 comments
Closed

Which algorithm ratelimit process is using ? #269

santinoncs opened this issue Jul 26, 2021 · 2 comments

Comments

@santinoncs
Copy link

I am not able to find in the documentation which strategy is using the process to rate-limit.

Token bucket, Leaky bucket , Fixed window, Sliding window

thanks

@chrishowell
Copy link

chrishowell commented Jul 27, 2021

It's Fixed Window at the moment:

b.WriteString(strconv.FormatInt((now/divider)*divider, 10))

There's a PR for Sliding Window that's been open for many months, gone stale, and been closed.
Also see #32

@santinoncs
Copy link
Author

And why we are not considering token or leaky bucket as we do in local rate limit?
What would be the difference? I don't think consistency is needed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants