Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the default hitsAddend configurable #730

Closed
gcalmettes opened this issue Oct 10, 2024 · 5 comments
Closed

Make the default hitsAddend configurable #730

gcalmettes opened this issue Oct 10, 2024 · 5 comments
Labels

Comments

@gcalmettes
Copy link

The current minimum hitsAddend value is set to 1 (enforced via a Max function). This prevents uses cases where the request itself would not carry any "weight" (e.g.: request to check a quota).

Could we make the minimum hitsAddend value configurable so 0 could also be a possible hitsAddend value for a request ?

@gcalmettes
Copy link
Author

PR for a proposed implementation, leveraging the current Settings.

Copy link

github-actions bot commented Nov 9, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 9, 2024
@gcalmettes
Copy link
Author

not stale

@github-actions github-actions bot removed the stale label Nov 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 9, 2024
Copy link

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant