Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] rate limit expiration #800

Open
yusofg2 opened this issue Dec 18, 2024 · 0 comments
Open

[Feature request] rate limit expiration #800

yusofg2 opened this issue Dec 18, 2024 · 0 comments

Comments

@yusofg2
Copy link

yusofg2 commented Dec 18, 2024

Use-case: Some rate limits are needed for a relatively short period of time (e.g. under an incident). If ratelimits had an expiry time, the service operator does not need to manually remove the limits that are no longer needed or relevant.

Rationale: The ratelimit service configuration and logic does not accommodate rate limit expiry timestamps. To implement rule expiry, an external control plane needs to remove the rate limits when they expire and update the ratelimit service configuration. If the service handled ratelimit expiry, similar to many ruleset engines, it would be more self-contained.

Possible config example shown in the last line below (adapted from here):

  - key: foo
    rate_limit:
      unit: minute
      requests_per_unit: 2
    descriptors:
      - key: bar
        rate_limit:
          unit: minute
          requests_per_unit: 3
      - key: bar
        value: bkthomps
        rate_limit:
          name: bkthomps
          unit: minute
          requests_per_unit: 1
          expiry: 2025-01-01 12:00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant