Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text is almost invisible when using RGBA (in dark theme) #202

Open
Alyaqdhans opened this issue Apr 7, 2024 · 2 comments
Open

Text is almost invisible when using RGBA (in dark theme) #202

Alyaqdhans opened this issue Apr 7, 2024 · 2 comments

Comments

@Alyaqdhans
Copy link

As the title says the text is unreadable when the color is very transparent:
image

The text should be aware of the alpha channel in the RGB colors, if it's very transparent the text should be white.

@jasikpark
Copy link

Same problem for me using oklch:

image

It seems to only use black text regardless of the contrast ratio against the color?

@silverwind
Copy link

silverwind commented May 30, 2024

Here are some example values with bad contrast. Basically all low-opacity colors are affected.

  --color-markup-table-row: #e8f3ff0f;
  --color-markup-code-block: #e8f3ff12;
  --color-markup-code-inline: #e8f3ff28;
image

Also I wonder why it renders two background rectangles, which may be a separate bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants