Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitizers incompatible with depends_on_llvm #17

Open
aaronmondal opened this issue Dec 12, 2022 · 4 comments
Open

Sanitizers incompatible with depends_on_llvm #17

aaronmondal opened this issue Dec 12, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@aaronmondal
Copy link
Contributor

We are missing #include <sanitizer/msan_interface.h>. Probably caused by drift from upstream. Should be easy to fix.

@aaronmondal aaronmondal added the bug Something isn't working label Dec 12, 2022
@aaronmondal aaronmondal self-assigned this Dec 12, 2022
@aaronmondal
Copy link
Contributor Author

Magically fixed itself when bumping LLVM 😆

@aaronmondal
Copy link
Contributor Author

Nope, still occurs

@aaronmondal aaronmondal reopened this Dec 21, 2022
@neqochan
Copy link
Contributor

The issue only occurs when using depends_on_llvm, since the original LLVM overlay doesn't include the compiler-rt headers. A simple solution may be to just patch the overlay. I'm not sure whether it is trivial to upstream such a change though since upstream doesn't have an overlay for compiler-rt at all.

@aaronmondal
Copy link
Contributor Author

This is becoming a larger issue. The ROCm stack depends on LLVM so we can't sanitize it at the moment. We should fix this as soon as we have more test coverage around ROCm so that we can run a sanitized test suite.

@aaronmondal aaronmondal changed the title Msan broken Sanitizers incompatible with depends_on_llvm Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants