Large number of tests broken under the nix sandbox

[eopb]

The nix package manager exposes a way to run tests. To improve reproducibility, these tests are sometimes run within the nix sandbox. This sandbox environment causes some of our tests to fail.

Some of these tests fail because internet access is disabled inside the sandbox. I expect those tests won't be as easy to fix as the others since we have to mock the outside world.

Currently, to enable nix flake check to run without error, we disable these problematic tests.

cargo-override/flake.nix

Lines 59 to 73 in 34a0538

	checkFlags = [
	# Broken when run under the nix sandbox
	"--skip=cli_tests::override_subcommand_help_message"
	"--skip=git::git_patch"
	"--skip=git::git_patch_branch"
	"--skip=git::git_patch_branch"
	"--skip=git::git_patch_rev"
	"--skip=git::git_patch_tag"
	"--skip=git::git_patch_tag"
	"--skip=git::git_patch_version_missmatch"
	"--skip=git::git_patch_version_missmatch"
	"--skip=missing_manifest"
	"--skip=patch_absolute_path"
	"--skip=patch_manifest_doesnt_exist"
	];

Tests to fix

• cli_tests::override_subcommand_help_message
• git::git_patch
• git::git_patch_branch
• git::git_patch_branch
• git::git_patch_rev
• git::git_patch_tag
• git::git_patch_tag
• git::git_patch_version_missmatch
• git::git_patch_version_missmatch
• missing_manifest
• patch_absolute_path
• patch_manifest_doesnt_exist