Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semver-checks? #9

Closed
peter-lyons-kehl opened this issue Oct 6, 2023 · 2 comments
Closed

semver-checks? #9

peter-lyons-kehl opened this issue Oct 6, 2023 · 2 comments

Comments

@peter-lyons-kehl
Copy link
Contributor

I know you, cargo team & Predrag are working toward incorporating cargo-semver-checks into cargo (obi1kenobi/cargo-semver-checks#61). But would it make sense to make your template use cargo-semver-checks or https://github.com/obi1kenobi/cargo-semver-checks-action?

Also, FYI

@epage
Copy link
Owner

epage commented Oct 6, 2023

Last I looked at cargo-semver-checks, the action expects you to bump the version during development, rather than at release, which is counter to my workflow (and a lot of other workflows seeing as cargo-release was changed to be like this).

I use cargo-release for my releases and it manages a lot of complex cases a simple justfile wouldn't handle. I am looking at release-plz for some specific cases and it has a lot of limitations.

@epage
Copy link
Owner

epage commented Oct 6, 2023

Ah, didn't realize how old that fasterthanlime post is. I thought it was part of his recent research into release-plz to make releases for libc easier

@peter-lyons-kehl peter-lyons-kehl closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants