Adding package docs, inline comments for readability, testing, client, docker examples #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… proxy chains respectively
Lut99
requested changes
Sep 29, 2023
There was a problem hiding this comment.
Overall, great work! The socksx-crate instantly got bumped from a really mysterious crate to a very workable one! :D
I've left quite a few comments, but not everything is necessary to merge the PR, just for if you have more time and like this kind of work. Anything you've already done is amazing :) I marked the ones I think we have to address, but that can also be by disagreeing with me ;)
Lut99
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stats -