Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile time checking #171

Closed
gilesknap opened this issue Jan 26, 2024 · 1 comment
Closed

compile time checking #171

gilesknap opened this issue Jan 26, 2024 · 1 comment

Comments

@gilesknap
Copy link
Member

gilesknap commented Jan 26, 2024

There are a number of things that don't get checked until runtime inside IOCs. At present we mostly rely on the schema helping us make sure our YAML is good when we are editing in a YAML checking editor.

Things we should do in the container build:

  • validate the schema of all support YAML
  • check support YAML for duplicate definition id's
  • check support YAML for database template references to non-existent files
  • ANYTHING ELSE?

Also it occurs to me that ec ioc validate for checking ioc instance yaml is woefully inadequate. At present it gets a container with a schema checker in it.

It would be far more instructive to instead fetch the generic IOC container it refers to and check it can generate the runtime assets inside of that - and launch the binary. That would pick up all possible errors that can occur. Including those that are currently missing.

This issue supersedes #170 so will be closing that.

@gilesknap
Copy link
Member Author

The CI for ibek-support, beamline repos and even for generic iocs has got much more sophisticated since writing this issue.

Because the beamline repo CI generates runtime assets for all its IOC instances all of the points in the OP are covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant