Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow numbers to be group names #141

Open
GDYendell opened this issue Oct 18, 2024 · 3 comments
Open

Allow numbers to be group names #141

GDYendell opened this issue Oct 18, 2024 · 3 comments
Assignees

Comments

@GDYendell
Copy link
Member

ValidationError: 1 validation error for Group
name
  String should match pattern '^([A-Z][a-z0-9]*)*$' [type=string_pattern_mismatch, input_value='0', input_type=str]
    For further information visit https://errors.pydantic.dev/2.9/v/string_pattern_mismatch
@GDYendell
Copy link
Member Author

This might not be possible because qsrv / pvaccess does not allow fields starting with a number, so the PVI info creation fails:

ODIN:FP:PVI: Error Group not created: invalid field name "0"
ODIN:FR:PVI: Error Group not created: invalid field name "0"

@GDYendell
Copy link
Member Author

Maybe the generation of pvaccess group names could insert a character at the front, but would need to check if this affects the introspection - does the group name itself actually matter, or only the leaves?

@gilesknap
Copy link
Member

I recently fixed this issue in epics-containers startup by changing how I generated the names. I had been using {camera-id}-{xxx} and when camera id was an IP address the schema validation failed.

I felt that this was a reasonable schema and I should fix the problem from outside of PVI.

@GDYendell GDYendell moved this from In Progress to Backlog in FastCS Development Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants