Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle NDFile Inheritance #75

Open
GDYendell opened this issue Jan 19, 2024 · 1 comment
Open

Handle NDFile Inheritance #75

GDYendell opened this issue Jan 19, 2024 · 1 comment
Milestone
1.0

Comments

@GDYendell
Copy link
Member

Currently in ADCore the parameters for NDFile are in asynNDArrayDriver, but the records are in NDFile.template. This is so that the parameters can be used in file plugins and ADPilatus. We don't want to mirror this because it then includes these signals on the generated UIs for all areaDectector plugins and drivers.

Instead, we should implement multiple inheritance in Device. Then we an make an NDFile.pvi.device.yaml with the parameters and then update NDFilePlugin and ADPilatus to include both their parent driver and NDFile.
@GDYendell GDYendell added this to the 1.0 milestone Jan 19, 2024
@GDYendell
Copy link
Member Author

The parent field should be replaced with includes to better match the way templates work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@GDYendell