Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right-click menu #799

Closed
nesadrian opened this issue Sep 9, 2024 · 10 comments · Fixed by #800
Closed

Right-click menu #799

nesadrian opened this issue Sep 9, 2024 · 10 comments · Fixed by #800
Assignees
Labels
feat New feature or request front-end Frontend code, functionality, or client-side interactions

Comments

@nesadrian
Copy link
Contributor

nesadrian commented Sep 9, 2024

https://www.figma.com/design/SacZjN10goX2lahJrmjWC0/Flyt--%3E-Ideation?node-id=1117-139714&t=wKCLRU4ELQ1c3LAZ-4

@nesadrian nesadrian added feat New feature or request front-end Frontend code, functionality, or client-side interactions labels Sep 9, 2024
@nesadrian nesadrian self-assigned this Sep 9, 2024
@nesadrian nesadrian linked a pull request Sep 14, 2024 that will close this issue
@nesadrian
Copy link
Contributor Author

@QiJin-Bouvet This is ready for test

@QiJin-Bouvet
Copy link

QiJin-Bouvet commented Sep 30, 2024

Tested with commit 18dc87a in TEST env.

  • Right-click menu missing in Tutorial
  • Maybe remove the backspace symbol besides 'Delete' until it get implemented?
  • Some options in the right-click menu for green cards should be disabled/hidden.

image

@nesadrian
Copy link
Contributor Author

@QiJin-Bouvet Ready for test again. Thanks for feedback. I removed the backspace icon until the delete shortcut has been implemented. We have a separate issue for the copy and paste tutorial. I had a talk with Vetle and that is a good enough tutorial for now.

@KaterynaBasik
Copy link
Contributor

KaterynaBasik commented Oct 2, 2024

Tested in Test env:
Here are some results from my end. Needs to be discussed

  • 1. Sometimes right-click menu appears far from the selected card

image
image

  • 2. Regardless of what user choses while adding (Add - Left or Add- Right), a new card is added to the left. It works same way in production

image

  • 3. Opened right-click menu is disappeared when user click LMB somewhere but isn't disappeared when user holds LMB and move canvas

  • 4. By doing Ctrl+C -> Ctrl+V I changed the default SIPOC order somehow. Trying to reproduce this case

image

  • 5. Process goes crazy when deleting main activity with choice cards
    image

  • 6. Sometimes when adding a choice card to the Main activity it creates only one sub-activity
    image

  • 7. If user does Ctrl+C -> Ctrl+V actions with the same Main activity card it deletes all connected cards and keeps only main activity card
    image

Discuss:

  • What do we do with Left and Right options?
  • What is the value of Add action in the right-click menu if this can be done by existing functionality with fewer steps?

@nesadrian
Copy link
Contributor Author

@KaterynaBasik

  1. Do you know how to reproduce this? I have not encountered this issue yet.
  2. The cards are being added in the right order, but not displayed in the right order. There is an issue on this here Wrong order choice children #813
    3, 5: I'll fix it.
    4, 6, 7: From the testing I have done these all seems to be connected to the same problem. I'll fix it.

As discussed in the meeting the Add action serves as a secondary option for users who prefer to do it this way even though it's slower

@KaterynaBasik
Copy link
Contributor

@KaterynaBasik

  1. Do you know how to reproduce this? I have not encountered this issue yet.

I can't reproduce this anymore 🤔😃

@nesadrian
Copy link
Contributor Author

@QiJin-Bouvet @KaterynaBasik This is ready for test

@KaterynaBasik
Copy link
Contributor

KaterynaBasik commented Oct 11, 2024

Tested in Test

@nesadrian
Copy link
Contributor Author

@KaterynaBasik Ready for test. Main activity copy paste has been fixed. I have also removed the option to add cards to the left of choice childrens as discussed. Number 2 will be fixed in it's separate issue.

@KaterynaBasik
Copy link
Contributor

Tested in Test

  • Add-Left option is not available now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request front-end Frontend code, functionality, or client-side interactions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants