Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo metadata aggregation #205

Open
berland opened this issue Mar 9, 2021 · 0 comments · May be fixed by #182
Open

Redo metadata aggregation #205

berland opened this issue Mar 9, 2021 · 0 comments · May be fixed by #182
Milestone

Comments

@berland
Copy link
Collaborator

berland commented Mar 9, 2021

In #182 , the metadata aggregation for summary vectors will be redone to make use of ecl2df's new feature for metadata

ecl2df.summary puts the needed meta-dictionary into dframe.attrs["meta"] for all summary keys returned.

ensemble.py should aggregate this metadata for all realizations and present this using the same attrs on returned dataframes.

The API get_smry_meta() will be less important, as meta is always returned.

Suggested changes to fmu.ensembles:

  • {realization/ensemble}.get_smry_meta() requires summary data to be preloaded, it will not go to disk to obtain requested summary data from libecl, only look through the attrs["meta"] in its internalized frameds
  • the column_keys argument to get_smry_meta() is dropped, as it seems unnecessary to code slicing of aggregated dictionaries on users behalf.
@berland berland linked a pull request Mar 11, 2021 that will close this issue
6 tasks
@berland berland added this to the 2.0 milestone Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant