Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inspection data to be gathered in events, not just by API calls #626

Open
andchiind opened this issue Oct 14, 2024 · 0 comments
Open
Assignees
Labels
feature New feature or request

Comments

@andchiind
Copy link
Contributor

Describe the new feature you would like to see
Currently we collect and upload inspection data by making a function call to robotinterface, which in turn return the inspection data in a synchronous way. It is natural for many robots to process the inspection data asynchronously and therefore return the inspection data in an event based manner. I would like ISAR to support such a setup.

Describe the solution you'd like
There should be a config option that sets whether inspection data is gathered by calling the "get_inspections" function in robotinterface, or if ISAR should use an event handler which can be registered using a new function in robotinterface. ISAR should use this event handler to automatically upload inspection data as soon as it is received.

This should not be a breaking change as long as the current inspection data uploading is kept as the default in settings.py.

How will this feature affect the current Threat Model?
N/A, as the connections used for the events are handled in the respective ISAR implementations.

@andchiind andchiind added the feature New feature or request label Oct 14, 2024
@andchiind andchiind changed the title Allow inspection data to be gathered in events, not just by REST API Allow inspection data to be gathered in events, not just by API calls Oct 14, 2024
@andchiind andchiind self-assigned this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant