Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency to Active Cluster - active cluster name #1068

Open
3 of 6 tasks
nilsgstrabo opened this issue Mar 19, 2024 · 1 comment
Open
3 of 6 tasks

Remove dependency to Active Cluster - active cluster name #1068

nilsgstrabo opened this issue Mar 19, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@nilsgstrabo
Copy link
Contributor

nilsgstrabo commented Mar 19, 2024

External DNS, app alias and active cluster ingresses are only created when cluster name matches active cluster name (defined in flux).
This made sense when we used external-dns to managed DNS records in the DNS zones based on ingress objects in Kubernetes, but now that we use wildcard DNS records there is no need to differentiate between active and non-active clusters when it comes to ingresses. All ingresses should be created regardless of active cluster state.

DoD
Works as before, operator will not start creating/removing ingresses when a new cluster is deployed

@nilsgstrabo nilsgstrabo added the enhancement New feature or request label Mar 19, 2024
@emirgens emirgens changed the title Create all ingresses regardless whether the cluster is active cluster or not Remove dependency to Active Cluster - active cluster name Oct 16, 2024
@Richard87 Richard87 self-assigned this Oct 17, 2024
@Richard87
Copy link
Contributor

Richard87 commented Oct 22, 2024

Currently RADIX_PUBLIC_DOMAIN_NAME is reverted to contain the domain from RADIX_CANONICAL_DOMAIN_NAME when its not active.

  • this can help with testing during cluster migration (if the application is using RADIX_PUBLIC_DOMAIN_NAME during auth for example to redirect back to the application, and they are using their own oauth provider)

  • but it can also be wrong during migration (if they are submitting the domain to 3rd parties for callbacks, if the cluster is shut down before the callback, the will lose the information, if they assumed RADIX_PUBLIC_DOMAIN_NAME always points to the active cluster/application)

I would like to simplify the logic, this is also the last step for the operator to not need to know what cluster is active

We have decided to simplify, RADIX_PUBLIC_DOMAIN_NAME will always be public, and never changed to canonical in standby-clusters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants