Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a context provider wrapping view and settings components in order to more easily access framework helpers #727

Open
rubenthoms opened this issue Sep 17, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@rubenthoms
Copy link
Collaborator

rubenthoms commented Sep 17, 2024

Implement a module-instance-specific context and provide it to settings and view components. This context could provide workbench and module instance information (session, services, settings). Specific hooks could then use this context in order to provide functionality like adding messages to the status writer or get ensembles etc.

Advantages

  • Reduce prop-drilling
  • Make framework-interaction easier accessible
  • Easier task-related code separation
  • Very React-ish

Disadvantages

  • Might be harder to see what goes where / who is consuming what
@rubenthoms rubenthoms added enhancement New feature or request question Further information is requested labels Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Status: Backlog 📝
Development

No branches or pull requests

6 participants