Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer filters broken? #1187

Open
Kikimanox opened this issue Apr 13, 2024 · 2 comments
Open

Prefer filters broken? #1187

Kikimanox opened this issue Apr 13, 2024 · 2 comments

Comments

@Kikimanox
Copy link

Kikimanox commented Apr 13, 2024

Hello. I am trying to setup some prefer filters for my downloads but I can't get them to work, are they broken? Nothing makes sense. Please take a look at this image:

chrome_2024_04_13_19-35-56

As an example I try to prefer SubsPlease if possible. And 700MB+ if possible.

Lets go trough the image:

  1. 700MB+ pref. filter and SubsPlease together. Here only the Size one works (the SubsPlease doesn't tho....)
  2. FileSize filter alone. It does not work. (why did it work before, what?)
  3. SubsPlease filter alone. It does work.

I am starting to lose hope with the prefer filters, been changing them every day and they keep acting very unexpectedly weird and don't want to work as expected. Any ideas?

@erengy
Copy link
Owner

erengy commented Apr 13, 2024

Hi there,

  1. Note that the filter is set up to match "Any condition" (see Question about filters that has multiple condition. #1186 for a similar question).

  2. I get different results with the same filter (only >700 MiB files are selected as expected). Might be because you have other filters interfering.

Nothing makes sense.

It's not you. Preference filters have some rather obscure details (they behave differently depending on the filter's limits, other filters, filter ordering and search results), so I understand the confusion. I'm planning to work on this some time after v2. Until then, I'd recommend avoiding preference filters where possible and using specific filters that select exactly what you want.

@Kikimanox
Copy link
Author

Kikimanox commented Apr 14, 2024

Hi @erengy

Thank you very much for the reply, and apologies for the lesser formality and structure in my issue opener message. Love the program and the effort that went into it, really great job! Been using it for years.

Now, to further elaborate and ease you trying to reproduce any possible issue in the code or filter setup themselves I will outline my state more in detail:

My anilist is kiki which can be used for temporary testing if needed. My current taiga version is 1.4.1.

I deleted the data/feed/history.xml file from appdata to not cause any caching interfierence.

Before going back to my example I would like to explain the reason why I even want to setup the prefer filters to get better understanding:

  1. Before I had only a discard filter and select filter that selected only SubsPlease releases for examples. For airing anime (seasonals)
  2. It's been happening that some seasonals (usually those that aren't on CR, so like netflix shows or some other streaming services...) don't get picked up by SubsPlease so I wanted to capture those in the auto downloading too.

The RSS feed used for checking new releases is: https://nyaa.si/?page=rss&q=1080&c=1_2&f=1 (and for searching releases for a title: https://nyaa.si/?page=rss&c=1_2&f=0&q=%title% which is used for the Dungeon Meshi test since RSS feed is well.. limited to last 150 entries and kinda hard to test with that but I assume new releases and searching release sshould both work the same way?) I wanted to initially use f=2 to only capture trusted releases but that fails for Dungeon Meshi specifically since COPiUM stopped ripping it)

To test I am providing the export of my currently seemingly broken filters (to go back to the preference filter issue)

VEFJAQUAMS40LjE/AdQEeJytlF9PwyAUxZ/1UxCSPa8z/k1aHxZfTUz0vbmD20lCocKlpn56y7q51di6aZ8IKefXw4FDqghLBoKUNRmXygtwkrMSSLxmHEzDma22HzEuq4GQMzSw0igzTi60UwMlZvxhq74/P0uFNVJFHUONJRrKOFbKW4l5rSTa3KG3OsQV8Q/ogKzLuLGEbwG056wGHVroIrlNKs7mA1BtBeh8h4YalI7ODpnfgC8bx0O8HcmEcoVuBDN7jxGhnA2zgkeXewIKfgSUDAMKpTEXbeBr65oRxDJaOdnHD1n/nkt3eNRUvYhbAYEye9LF9eVkLKin9HU1Gauu7jasdB471I69KvkWK2jfJK0Pm1RA0DRQo+dO+Y8WnVah467pYmSvlcMiluVPr8ZTJx6rgFcfvaNY05etmyRhj2rZM/cJLSusxg==

In text form:
Discard = ep not 1080p || ep is available already (I assume this means downloaded) || ep is %watched% || ep is not in list || file category is batch || anime status is not cur. watching || anime video type containes (264|av1|265|vp9|hevc)
Select = 1080p && currently watching
Prefer = in the export above I only set it to File Size > 700 MiB... (match any condition, deactivate discarded items)

Results ... well we as I already explained in the picture in the issue opener ... results not as expected:
image

Furthermore, if the prefer filter will work correctly either trough a hotfix or explaining how I am doing something wrong... the ideal prefer filter I would want to setup is, in this priority ofc:

  1. Group is SubsPlease (we take these if exists)
  2. Group is CR (thats actually NanDesuKa but their releases are still better than Erai-raws ...)
  3. File Size > 700 MiB
  4. File Size > 1.3 MiB (usually the higher size ones are better in case anyone encoded something poorly and uploaded it alltho the discard filter should probs already deal with that)
  5. Episode version is greater than 1 (ideally the biggest version available) (so like v2/v3...)

(both 3. and 4. are there because I already saw release at like 300MB, 750MB and 1.4MB or something, but also releases at 300MB and 900MB only...)

But ye, going into a 5 step filter like this would be cool but can't even start preparing it since not even a simple file size is greater than isn't working...

Thank you in advance for checking this out and possible either figuring what the issue is.

(Ofc down the line I'd also add prefer filters for fansubs if any anime gets that, for example in this season Girls Band Cry didn't get picked up by any licenser so ye.. SobsPlease looks like the fansubs group for those to go with, great job to them :D )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants