Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Treq generator #17

Closed
wants to merge 8 commits into from
Closed

Add Treq generator #17

wants to merge 8 commits into from

Conversation

exarkun
Copy link
Contributor

@exarkun exarkun commented Jan 9, 2019

Fixes #16
Stacked on top of #15 so that should be reviewed first.

@erewok
Copy link
Owner

erewok commented Jan 12, 2019

This is great: I've never used treq, but I don't seen any problem including a new generator, and it's good that you added tests for it.

Two questions:

  1. Do you want to add a treq build to the examples, something like writeTypedPythonForAPI testApi treq (result </> "api_treq.py") at the bottom of this module?

  2. I never throw blank Exceptions in Python. Do you want to create a custom exception or throw something closer to the type of Exception we're expecting to see here. (Also, does this Exception line work: does it coerce the resp into a string?)

@erewok erewok closed this Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate treq-using Python client code
2 participants