Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller alert methods should be extension methods rather than BootstrapBaseController #86

Open
jarrettv opened this issue Mar 20, 2013 · 3 comments

Comments

@jarrettv
Copy link

I suggest Attention, Success, Information, and Error are made extension methods.

@erichexter
Copy link
Owner

I am cool including this as a pull request.

On Wed, Mar 20, 2013 at 3:23 PM, Jarrett Vance [email protected]:

I suggest Attention, Success, Information, and Error are made extension
methods.


Reply to this email directly or view it on GitHubhttps://github.com//issues/86
.

@serra
Copy link
Contributor

serra commented Mar 21, 2013

👍

I'm not sure what the Update-Package twitter.bootstrap.mvc4 will do if BootstrapBaseController is unmodified. It might remove the file, possibly breaking client code. Please check this and handle it gracefully.

@erichexter
Copy link
Owner

So let me rephrase my support for this. Move the existing logic into
extension methods and change the existing controller base to call these
from the existing helper methods.
On Mar 21, 2013 4:11 AM, "Marijn van der Zee" [email protected]
wrote:

[image: 👍]

I'm not sure what the Update-Package twitter.bootstrap.mvc4 will do if
BootstrapBaseController is unmodified. It might remove the file, possibly
breaking client code. Please check this and handle it gracefully.


Reply to this email directly or view it on GitHubhttps://github.com//issues/86#issuecomment-15225965
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants