Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fails to build with glibc 2.38 #385

Closed
fredclausen opened this issue Nov 17, 2023 · 5 comments
Closed

fails to build with glibc 2.38 #385

fredclausen opened this issue Nov 17, 2023 · 5 comments

Comments

@fredclausen
Copy link

The issue/discussions here describes the issue. Basically, compilation fails because glibc 2.38 includes strlcpy in String.h and then attempts to redefine it.

@MarijnS95
Copy link
Contributor

That issue not only describes the problem but has also been closed because it was fixed and published under a semver-compatible release. Is this a duplicate and stale report in the wrong repository?

Perhaps you still have zeromq-src bound to an older version via Cargo.lock locally. Try running cargo update -p zeromq-src to make sure it's on version 0.2.6.

@MarijnS95
Copy link
Contributor

MarijnS95 commented Nov 17, 2023

One notable exception is cross-compiling; I submitted a followup fix to the repository (jean-airoldie/zeromq-src-rs@21056e9) that only seems to have made it into the semver-incompatible 0.3.0 release.

For that action in this repository is needed. I'll push that soon.

@fredclausen
Copy link
Author

That issue not only describes the problem but has also been closed because it was fixed and published under a semver-compatible release. Is this a duplicate and stale report in the wrong repository?

Perhaps you still have zeromq-src bound to an older version via Cargo.lock locally. Try running cargo update -p zeromq-src to make sure it's on version 0.2.6.

I was confused because I knew upstream had fixed the issue, and I thought this library was locked in to an older version. I was wrong, and forcing cargo to update fixed it. Thank you for that!

@MarijnS95
Copy link
Contributor

For completeness, if you believe an issue has been fixed upstream and action is needed in a downstream repository to consume it, do mention so from the get-go :)

@MarijnS95
Copy link
Contributor

For that action in this repository is needed. I'll push that soon.

Version bump pushed in #386.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants