New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Json package readme #1

Closed

ericstj wants to merge 6 commits into main from JsonPackageReadme

Owner

ericstj commented Aug 3, 2023

No description provided.


          Updating Json package readme

c619ebe

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/PACKAGE.md Show resolved Hide resolved

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/PACKAGE.md Outdated Show resolved Hide resolved

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/PACKAGE.md Show resolved Hide resolved

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/PACKAGE.md Outdated Show resolved Hide resolved

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/PACKAGE.md Outdated Show resolved Hide resolved

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/PACKAGE.md Outdated Show resolved Hide resolved

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/PACKAGE.md Outdated Show resolved Hide resolved

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/PACKAGE.md Outdated Show resolved Hide resolved

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/PACKAGE.md Outdated Show resolved Hide resolved

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/PACKAGE.md Outdated Show resolved Hide resolved

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/PACKAGE.md Outdated Show resolved Hide resolved

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/PACKAGE.md Outdated Show resolved Hide resolved

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/PACKAGE.md Show resolved Hide resolved

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/PACKAGE.md Show resolved Hide resolved

eiriktsarpalis reviewed

View reviewed changes

src/libraries/System.Text.Json/src/PACKAGE.md Show resolved Hide resolved

ericstj and others added 5 commits

August 3, 2023 12:32


          Update src/libraries/System.Text.Json/src/PACKAGE.md

8f3f8f9

Co-authored-by: Eirik Tsarpalis <[email protected]>


          Apply suggestions from code review

868dca1

Co-authored-by: Eirik Tsarpalis <[email protected]>


          Remove sharplab comment


          Update PACKAGE.md

ef73228


          Update PACKAGE.md

ericstj closed this

Owner Author

ericstj commented Aug 7, 2023

Will submit this one to dotnet/runtime.

ericstj pushed a commit that referenced this pull request


          Clear IconHandle when we fold compares (dotnet#95383)

b95bccb

Fixes dotnet#95367.

Relevant part of the JitDump:

```
Using `if true` assertions from pred BB02
Assertions in: #1
fgMorphTree BB04, STMT00021 (before)
               [000070] DA---------                         *  STORE_LCL_VAR ubyte  V10 tmp9
               [000057] -----------                         \--*  CAST      int <- ubyte <- int
               [000006] -----------                            \--*  EQ        int
               [000004] -----------                               +--*  LCL_VAR   ref    V02 tmp1          (last use)
               [000055] H----------                               \--*  CNS_INT(h) ref     'Frozen EmptyPartition`1<Int32> object'

Assertion prop for index #1 in BB04:
               [000006] -----------                         *  EQ        int
GenTreeNode creates assertion:
               [000070] DA---+-----                         *  STORE_LCL_VAR ubyte  V10 tmp9
In BB04 New Local Constant Assertion: V10 == [0000000000000001], index = #2

fgMorphTree BB04, STMT00021 (after)
               [000070] DA---+-----                         *  STORE_LCL_VAR ubyte  V10 tmp9
               [000055] H----+-----                         \--*  CNS_INT(h) int
```

The JitDump is unfinished because the compiler crashes when trying to dump the last line. Clearly, the `CNS_INT` is no longer a handle at that point because we just bashed it to a constant 1.

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet