Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create database fails when an empty createDatabase folder is present #532

Open
theiam79 opened this issue May 29, 2024 · 0 comments
Open

Comments

@theiam79
Copy link

Describe the bug
If an empty createDatabase folder exists, grate does not fall back to the default creation script, so no database is created.

To Reproduce
Create all default folders for grate, leaving createDatabase empty. Attempt to run a migration targeting a database that doesn't exist.

Expected behavior
The default creation script to be used (or clearer docs about which folders can be safely left empty)

Desktop (please complete the following information):

  • OS: Windows 11
  • Version: 1.7.4

Additional context
This isn't really a huge issue, as I mostly stumbled into it because I created the entire folder schema while testing the tool. I think making it work like the other folders (where they are ignored if empty) or clearly documenting that it is an exception would be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant