Remove leading underscore from inlay hint (#1564)

erlang-ls · Oct 11, 2024 · 5959282 · 5959282
1 parent 5bde640
commit 5959282
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/apps/els_lsp/priv/code_navigation/src/inlay_hint.erl b/apps/els_lsp/priv/code_navigation/src/inlay_hint.erl
@@ -10,7 +10,7 @@ test() ->
     d(1, 2),
     e(1, 2),
     f(1, 2),
-    g(1, 2),
+    g(1, 2, 3),
     lists:append([], []).
 
 a(A1, A2) ->
@@ -36,6 +36,6 @@ e(_, _) ->
 f(_, _) ->
     ok.
 
--spec g(G1, any()) -> ok when G1 :: any().
-g(_, G2) ->
+-spec g(G1, any(), _) -> ok when G1 :: any().
+g(_, G2, _G3) ->
     ok.
diff --git a/apps/els_lsp/src/els_inlay_hint_provider.erl b/apps/els_lsp/src/els_inlay_hint_provider.erl
@@ -119,7 +119,9 @@ arg_hints(_Uri, _POI) ->
 arg_hint(#{from := {FromL, FromC}}, ArgName) ->
     #{
         position => #{line => FromL - 1, character => FromC - 1},
-        label => unicode:characters_to_binary(ArgName ++ ":"),
+        label => unicode:characters_to_binary(
+            remove_leading_underscore(ArgName) ++ ":"
+        ),
         paddingRight => true,
         kind => ?INLAY_HINT_KIND_PARAMETER
     }.

diff --git a/apps/els_lsp/test/els_inlay_hint_SUITE.erl b/apps/els_lsp/test/els_inlay_hint_SUITE.erl
@@ -93,6 +93,13 @@ basic(Config) ->
                 paddingRight => true
             },
 
+            #{
+                label => <<"G3:">>,
+                position => #{line => 12, character => 12},
+                kind => ?INLAY_HINT_KIND_PARAMETER,
+                paddingRight => true
+            },
+
             #{
                 label => <<"F1:">>,
                 position => #{line => 11, character => 6},