Maintainers Sync 2021-10-08

[robertoaloi]

Alan/Roberto

• Roberto: call hierarchy landed. Looks good
• Roberto: creating a “doctor” command to erlang_ls
  • Goes through each running instance, picks up info, prints it
  • Can be used to debug setups, or provide context for bug reports
  • Alan: hls uses —lsp flag, runs doctor by default
• Roberto: improving error messages on server start failure
  • Show message to the user in case of language server starting error microsoft/vscode-languageserver-node#824 (comment)
• Roberto: considering using attributes to fine-tune the compiler, like rust compiler attributes to e.g. turn off dead code warnings
• Roberto: cleaning up the code a bit too
  • And considering ways of making it easier to set up tests
    • Cut them in half in terms of code
  • Alan: perhaps get rid of constructing atoms from strings and calling them, e.g. https://github.com/erlang-ls/erlang_ls/blob/main/apps/els_lsp/src/els_code_lens.erl#L110
  • Roberto: also impose functional api on key parts like poi(), rather then deconstruction all over the place