Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sys.config.src in shell and ct? #1981

Closed
tsloughter opened this issue Dec 18, 2018 · 6 comments
Closed

Support sys.config.src in shell and ct? #1981

tsloughter opened this issue Dec 18, 2018 · 6 comments

Comments

@tsloughter
Copy link
Collaborator

Should shell and ct support a config src and replace environment variables in them before applying?

@ferd
Copy link
Collaborator

ferd commented Dec 18, 2018

we certainly could. Does relx expose any functions I could lift for that or we should do variable expansion in duplicate?

@tsloughter
Copy link
Collaborator Author

It isn't in relx but in the start scripts, so would need to be duplicated.

@UmanShahzad
Copy link

This would be great to have :)

@tsloughter
Copy link
Collaborator Author

@UmanShahzad it already is :). We just forgot to close this it looks like.

@tsloughter
Copy link
Collaborator Author

Err, forgot this says ct as well. It is not supported by common test provider and an issue just for that should be opened.

@UmanShahzad
Copy link

Ah yeah I was thinking about ct in this case, but it's great that it's available for shell already!

Made #2096.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants